Fix gcc compiler warning in testFun.cpp #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR AcademySoftwareFoundation#250 changed the %lx to %llx to suppress an MSVC warning, but it introduced a gcc warning, where uint64_t is long, not long long. Better to leave it as %lx and just cast to long. It's only a printf anyway. Signed-off-by: Cary Phillips <cary@ilm.com>
|
@fpsunflower, can you confirm that this doesn't re-introduce the MSVC warning you fixed in #250? Turns out that change introduced a gcc warning. |
|
Its probably ok, but I think it would be better to explicitly cast to |
Signed-off-by: Cary Phillips <cary@ilm.com>
|
Got it, and it looks like my first take failed on Windows anyway. Thanks. |
|
IMHO it's better to keep using the platform-independent fixed-width types whenever possible, but change the print specifiers to match instead: platform-independent "PRIx64" in this case from inttypes.h |
This shoudl properly avoid warnings on all platforms. Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
added a commit
to cary-ilm/Imath
that referenced
this pull request
Oct 31, 2022
* Fix gcc compiler warning in testFun.cpp PR AcademySoftwareFoundation#250 changed the %lx to %llx to suppress an MSVC warning, but it introduced a gcc warning, where uint64_t is long, not long long. Better to leave it as %lx and just cast to long. It's only a printf anyway. Signed-off-by: Cary Phillips <cary@ilm.com> * cast to unsigned long long for %llx Signed-off-by: Cary Phillips <cary@ilm.com> * In printf, bit_cast to uint<n>_t and use PRIx<n> This shoudl properly avoid warnings on all platforms. Signed-off-by: Cary Phillips <cary@ilm.com> Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
added a commit
that referenced
this pull request
Nov 3, 2022
* Fix gcc compiler warning in testFun.cpp PR #250 changed the %lx to %llx to suppress an MSVC warning, but it introduced a gcc warning, where uint64_t is long, not long long. Better to leave it as %lx and just cast to long. It's only a printf anyway. Signed-off-by: Cary Phillips <cary@ilm.com> * cast to unsigned long long for %llx Signed-off-by: Cary Phillips <cary@ilm.com> * In printf, bit_cast to uint<n>_t and use PRIx<n> This shoudl properly avoid warnings on all platforms. Signed-off-by: Cary Phillips <cary@ilm.com> Signed-off-by: Cary Phillips <cary@ilm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #250 changed the %lx to %llx to suppress an MSVC warning, but it
introduced a gcc warning, where uint64_t is long, not long
long. Better to leave it as %lx and just cast to long. It's only a
printf anyway.
Signed-off-by: Cary Phillips cary@ilm.com