-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix check for the availability of std::bit_cast #346
Fix check for the availability of std::bit_cast #346
Conversation
Checking for the language version is not going to help for incomplete libraries such as on Apple or Android. This fixes this.
|
I don't believe that a change this small can be covered by copyright. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found the docs here ~ https://en.cppreference.com/w/cpp/feature_test ~ everything looks correct to me.
Filling out the CLA is straight forward, however if you're not interested in doing it for such a small change, we can go ahead and make the change ourselves.
Thank you. I spent the same amount it took me to look up the relevant macro name and write the patch trying to find the text of the CLA and failed. I'm sure that I can find it if I look for another 30 seconds :) The patch itself certainly fails all criteria for copyrightability even in the most ownership-friendly jurisdictions. So, I don't think it's a worthy pursuit for me to read and sign the CLA and I'm grateful that you offered to come up with the (likely identical) change yourself. |
See AcademySoftwareFoundation#346: Checking for the language version is not going to help for incomplete libraries such as on Apple or Android. This fixes this by using the bit_cast-specific macro. Signed-off-by: Cary Phillips <cary@ilm.com>
Closing in favor of #350 |
Thank you! |
See #346: Checking for the language version is not going to help for incomplete libraries such as on Apple or Android. This fixes this by using the bit_cast-specific macro. Signed-off-by: Cary Phillips <cary@ilm.com>
…ation#350) See AcademySoftwareFoundation#346: Checking for the language version is not going to help for incomplete libraries such as on Apple or Android. This fixes this by using the bit_cast-specific macro. Signed-off-by: Cary Phillips <cary@ilm.com>
…ation#350) See AcademySoftwareFoundation#346: Checking for the language version is not going to help for incomplete libraries such as on Apple or Android. This fixes this by using the bit_cast-specific macro. Signed-off-by: Cary Phillips <cary@ilm.com>
See #346: Checking for the language version is not going to help for incomplete libraries such as on Apple or Android. This fixes this by using the bit_cast-specific macro. Signed-off-by: Cary Phillips <cary@ilm.com>
Checking for the language version is not going to help for incomplete libraries such as on Apple or Android. This fixes this by using the
bit_cast
-specific macro.