Pybind11 and python unit tests #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ended to be written such that they work for both boost and pybind11. Signed-off-by: Lucas Miller <lmiller@imageworks.com>
…s from accidentally linking to boost. Build out more of PyImathVec to get it to pass the simple test. Signed-off-by: Lucas Miller <lmiller@imageworks.com>
This comment was marked as resolved.
This comment was marked as resolved.
lamiller0
commented
Oct 13, 2023
Signed-off-by: Lucas Miller <lmiller@imageworks.com>
Signed-off-by: Lucas Miller <lmiller@imageworks.com>
https://github.com/cinereal/Imath/tree/pybind11_unit_test Unit test contributions from Chris Gloor for ASWF Dev Days. Signed-off-by: Lucas Miller <lmiller@imageworks.com>
carefully compare the results with the boost python bindings. Add a couple more operators to the box that we will definitely need for future tests. Add a bunch of operators to PyImathVec to get almost all of the tests passing. Need to check on the argument order for closestVertex and project as the boost python bindings move them around without a clear doc string indicating it. Signed-off-by: Lucas Miller <lmiller@imageworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fill in Vec2, Vec3, and Vec4 stuff a little bit.
Create an area for python unit tests and fill in a basic example