Test CMake Config script #1421
Merged
Test CMake Config script #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rémi Achard <remiachard@gmail.com>
Signed-off-by: Rémi Achard <remiachard@gmail.com>
hodoulp
suggested changes
Jun 23, 2021
That's a good point. My answer is yes in OpenColorIO.h |
michdolan
reviewed
Jun 27, 2021
Signed-off-by: Rémi Achard <remiachard@gmail.com>
Signed-off-by: Rémi Achard <remiachard@gmail.com>
remia
force-pushed
the
feature/cmake-consumer-test
branch
from
5a225fe to
22a613d
Compare
hodoulp
approved these changes
Jun 28, 2021
michdolan
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up of #1397, adding a simple test of the generated script.
cxx_std_11public compiler feature on the core library based on @hodoulp suggestion.On a related note, I added an explicit warning ignore in the client project, the already known C4275. I wonder if we could do that from #pragma inside the source code (OCIO Exception class) to not impose that on the users.