-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove OpenColorIOHeaders target and hardcoded install paths #1471
Remove OpenColorIOHeaders target and hardcoded install paths #1471
Conversation
Signed-off-by: Rémi Achard <remiachard@gmail.com>
Signed-off-by: Rémi Achard <remiachard@gmail.com>
Updated install paths to use CMake automatic variables as suggested in #1296. Also updated public headers installation to use |
@remia Following the last commit, do you need to update the |
Signed-off-by: Rémi Achard <remiachard@gmail.com>
There is also some hard-coded |
Thanks @hodoulp good point, it seems like we should stop using |
Signed-off-by: Rémi Achard <remiachard@gmail.com>
@michdolan The PR is a candidate for |
@michdolan or @doug-walker The PR is close to the two-weeks rule, could one of you have a look? Thanks. |
* Remove OpenColorIOHeaders target Signed-off-by: Rémi Achard <remiachard@gmail.com> * Avoid hardcoding install paths Signed-off-by: Rémi Achard <remiachard@gmail.com> * Update remaining hardcoded install paths Signed-off-by: Rémi Achard <remiachard@gmail.com> * Replace LIB_SUFFIX by CMAKE_INSTALL_LIBDIR Signed-off-by: Rémi Achard <remiachard@gmail.com> Co-authored-by: Patrick Hodoul <patrick.hodoul@autodesk.com>
…1490) * Remove OpenColorIOHeaders target Signed-off-by: Rémi Achard <remiachard@gmail.com> * Avoid hardcoding install paths Signed-off-by: Rémi Achard <remiachard@gmail.com> * Update remaining hardcoded install paths Signed-off-by: Rémi Achard <remiachard@gmail.com> * Replace LIB_SUFFIX by CMAKE_INSTALL_LIBDIR Signed-off-by: Rémi Achard <remiachard@gmail.com> Co-authored-by: Patrick Hodoul <patrick.hodoul@autodesk.com> Co-authored-by: Rémi Achard <remiachard@gmail.com>
Since I'm not sure that I've been able to reproduce the undesired behavior on macos, I may not be the best person to review this PR, but I will say that OCIO builds and installs correctly with this PR. This said, I feel like at some point recently -- possibly as a result of locally merging an earlier WIP of this PR -- I did have to slightly modify my build script to provide better hints to CMake for finding my preferred Python interpreter. I wish I had kept better notes, or had a better memory, or both. I could be getting confused with stuff I had to update in my OpenImageIO build script. But to reiterate my earlier point, this builds and installs as it should, when using CMake best practices vis-a-vis python interpreter hints. |
@zachlewis I believe you meant to reply on #1510 ? I described some ways to reproduce the issues here which is not a common situation I guess. |
Oh whoops -- yep, that's the one I was going for. |
Following @lgritz comment in #1397, I think we can remove the
OpenColorIOHeaders
to simplify the CMake scripts a bit. I had some issues with documentation build because I first generated the OpenColorIOABI.h in a new location but resolved this by using the exact same target path as before which I think is the simplest solution.There shouldn't be a need to merge this for the upcoming release.