-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced "requireements" to "requirement" in installation.rst #1632
Conversation
@akhilsahuji the DCO check is failing because you need to sign-off your commit. The |
Also see the commit sign-off instructions in our CONTRIBUTING document: https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/main/CONTRIBUTING.md#commit-sign-off |
@michdolan I think it should merge now. |
Thanks @akhilsahuji . Your commits still need a sign-off to pass the DCO check. It will require amending your commits and force pushing to your branch. Please see the |
Signed-off-by: Akhil <46328560+akhilsahuji@users.noreply.github.com>
Signed-off-by: Akhil <46328560+akhilsahuji@users.noreply.github.com>
|
@michdolan the DCO is now fine. |
@michdolan I think that the PR is now ready. Could you approve and merge this pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @akhilsahuji and sorry for the delay.
Going to merge now.
Edit: Ah no, we are waiting for @michdolan do approve the requested change!
The highlighted word in the screenshot is wrong so I replaced it with the correct one.
Signed-off-by: Akhil Sahu akhil9415588049@gmail.com