Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced "requireements" to "requirement" in installation.rst #1632

Merged
merged 4 commits into from
Sep 6, 2022

Conversation

akhilsahuji
Copy link
Contributor

@akhilsahuji akhilsahuji commented Apr 17, 2022

The highlighted word in the screenshot is wrong so I replaced it with the correct one.
Signed-off-by: Akhil Sahu akhil9415588049@gmail.com
OCIO-issue

docs/quick_start/installation.rst Outdated Show resolved Hide resolved
@michdolan
Copy link
Collaborator

michdolan commented Apr 19, 2022

@akhilsahuji the DCO check is failing because you need to sign-off your commit. The Details link by the check has instructions for how you can fix it: https://github.com/AcademySoftwareFoundation/OpenColorIO/pull/1632/checks?check_run_id=6056478833

@michdolan
Copy link
Collaborator

Also see the commit sign-off instructions in our CONTRIBUTING document: https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/main/CONTRIBUTING.md#commit-sign-off

@akhilsahuji akhilsahuji marked this pull request as draft April 19, 2022 06:09
@akhilsahuji akhilsahuji marked this pull request as ready for review April 19, 2022 06:29
@akhilsahuji akhilsahuji marked this pull request as draft April 19, 2022 06:31
@akhilsahuji akhilsahuji marked this pull request as ready for review April 19, 2022 06:36
@akhilsahuji akhilsahuji marked this pull request as draft April 19, 2022 06:42
@akhilsahuji akhilsahuji marked this pull request as ready for review April 19, 2022 06:44
@akhilsahuji akhilsahuji requested a review from michdolan April 19, 2022 13:16
@akhilsahuji
Copy link
Contributor Author

@michdolan I think it should merge now.

@michdolan
Copy link
Collaborator

Thanks @akhilsahuji . Your commits still need a sign-off to pass the DCO check. It will require amending your commits and force pushing to your branch. Please see the Details link beside the failed check for instructions on fixing.

Signed-off-by: Akhil <46328560+akhilsahuji@users.noreply.github.com>
Signed-off-by: Akhil <46328560+akhilsahuji@users.noreply.github.com>
@akhilsahuji
Copy link
Contributor Author

Screenshot 2022-04-21 163225
Screenshot 2022-04-21 163308
@michdolan Rebased the branch and DCO check also passed it should merge now 🤞.

@hodoulp
Copy link
Member

hodoulp commented Apr 27, 2022

@michdolan the DCO is now fine.

@hodoulp
Copy link
Member

hodoulp commented May 4, 2022

@michdolan I think that the PR is now ready. Could you approve and merge this pull request?

Copy link
Collaborator

@remia remia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akhilsahuji and sorry for the delay.

Going to merge now.

Edit: Ah no, we are waiting for @michdolan do approve the requested change!

@michdolan michdolan merged commit 0620af7 into AcademySoftwareFoundation:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants