Fix python packaging #1778
Merged
Fix python packaging #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rémi Achard <remiachard@gmail.com>
doug-walker
approved these changes
Mar 17, 2023
cedrik-fuoco-adsk
approved these changes
Mar 21, 2023
cedrik-fuoco-adsk
pushed a commit
to autodesk-forks/OpenColorIO
that referenced
this pull request
Mar 24, 2023
Signed-off-by: Rémi Achard <remiachard@gmail.com> Co-authored-by: Doug Walker <doug.walker@autodesk.com> Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1759, that changed the Python distribution layout by adding a folder containing a
__init__.pyfile, I encountered some issues while using the Python bindings locally for development. TheRPATHwas no longer correct and the__init__.pyalso did not import everything (variables starting with underscores like__version__are not imported).This PR fix these issues and further try to have the in-build Python package structure close to the install so that unittest are performed in conditions that reflect the distributed package.
While all this is not strictly necessary for the wheels (they are built in static mode so the new
__init__.pyhas little use in the first place I'd imagine), I still updated the Python package structure in thesetup.pyso that it reflects what we do in the regular build process. This is to avoid having 2 different structures to maintain. I uploaded a new PyPI test version in case you want to compare and test. PyOpenColorIO is now a folder in site-packages, containing__init__.py,PyOpenColorIO.so|pyd,testsanddatamodules.