Add VFX 2024 to CI #2053
Merged
Add VFX 2024 to CI #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rémi Achard <remiachard@gmail.com>
Signed-off-by: Rémi Achard <remiachard@gmail.com>
Signed-off-by: Rémi Achard <remiachard@gmail.com>
Signed-off-by: Rémi Achard <remiachard@gmail.com>
doug-walker
approved these changes
Sep 23, 2024
|
I've updated the build matrix spreadsheet to reflect these changes (scroll down): |
zachlewis
approved these changes
Sep 23, 2024
|
Per the discussion at the TSC meeting today, we will go ahead and merge this one. The failing CI checks are not relevant. |
doug-walker
merged commit 145bce2
into
AcademySoftwareFoundation:main
55 of 61 checks passed
|
@doug-walker I forgot to mention that the names of the Linux jobs got updated so we will need to update Github required check list probably. |
|
It should be working (?), I updated the job names after I merged this. Please let me know if it needs more adjustment. |
|
Thanks @doug-walker, my bad, I was looking at a PR where the CI workflow was not triggered since the merge so it was missing required checks where the names changed, as expected. |
chrisnashdisguise
pushed a commit
to chrisnashdisguise/OpenColorIO
that referenced
this pull request
Oct 30, 2024
* Add VFX 2024 ASWF iamges to CI Signed-off-by: Rémi Achard <remiachard@gmail.com> * Bump CMake to 3.14 minimum to fix warning in FetchContent Signed-off-by: Rémi Achard <remiachard@gmail.com> * Fix error message formating Signed-off-by: Rémi Achard <remiachard@gmail.com> * Reduce warnings Signed-off-by: Rémi Achard <remiachard@gmail.com> --------- Signed-off-by: Rémi Achard <remiachard@gmail.com> Co-authored-by: Doug Walker <doug.walker@autodesk.com> Signed-off-by: Chris Nash <chris.nash@disguise.one>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding VFX 2024 Docker images from @jfpanisset to the CI workflow.
Also proposing a small bump in CMake minimum version to fix a warning appearing when using
FetchContent_Populateon latest CMake releases.