Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rqd broken #1037

Closed
jasonmads opened this issue Oct 1, 2021 · 0 comments · Fixed by #1047
Closed

rqd broken #1037

jasonmads opened this issue Oct 1, 2021 · 0 comments · Fixed by #1047
Labels
bug Something isn't working

Comments

@jasonmads
Copy link

jasonmads commented Oct 1, 2021

It appears that intercept channel was not implemented correctly and now rqd fails on start.

To Reproduce
Take the latest code and try to install and run rqd.

Expected behavior
It should run without error.

Screenshots
WARNING:root:RQD Starting Up
Traceback (most recent call last):
File "/cue/venv/bin/rqd", line 11, in
load_entry_point('rqd==0.14', 'console_scripts', 'rqd')()
File "/cue/venv/lib/python3.8/site-packages/rqd-0.14-py3.8.egg/rqd/main.py", line 134, in main
rqCore.start()
File "/cue/venv/lib/python3.8/site-packages/rqd-0.14-py3.8.egg/rqd/rqcore.py", line 620, in start
self.network.start_grpc()
File "/cue/venv/lib/python3.8/site-packages/rqd-0.14-py3.8.egg/rqd/rqnetwork.py", line 210, in start_grpc
self.grpcServer.serveForever()
File "/cue/venv/lib/python3.8/site-packages/rqd-0.14-py3.8.egg/rqd/rqnetwork.py", line 182, in serveForever
self.serve()
File "/cue/venv/lib/python3.8/site-packages/rqd-0.14-py3.8.egg/rqd/rqnetwork.py", line 176, in serve
self.connectGrpcWithRetries()
File "/cue/venv/lib/python3.8/site-packages/rqd-0.14-py3.8.egg/rqd/rqnetwork.py", line 158, in connectGrpcWithRetries
self.rqCore.grpcConnected()
File "/cue/venv/lib/python3.8/site-packages/rqd-0.14-py3.8.egg/rqd/rqcore.py", line 624, in grpcConnected
self.network.reportRqdStartup(self.machine.getBootReport())
File "/cue/venv/lib/python3.8/site-packages/rqd-0.14-py3.8.egg/rqd/rqnetwork.py", line 251, in reportRqdStartup
stub = self.__getReportStub()
File "/cue/venv/lib/python3.8/site-packages/rqd-0.14-py3.8.egg/rqd/rqnetwork.py", line 246, in __getReportStub
self.__getChannel()
File "/cue/venv/lib/python3.8/site-packages/rqd-0.14-py3.8.egg/rqd/rqnetwork.py", line 240, in __getChannel
self.channel = grpc.insecure_channel('%s:%s' % (cuebots[0],
File "/cue/venv/lib/python3.8/site-packages/grpc/init.py", line 1974, in insecure_channel
return _channel.Channel(target, () if options is None else options, None,
File "/cue/venv/lib/python3.8/site-packages/grpc/_channel.py", line 1475, in init
python_options, core_options = _separate_channel_options(options)
File "/cue/venv/lib/python3.8/site-packages/grpc/_channel.py", line 1455, in _separate_channel_options
if pair[0] == grpc.experimental.ChannelOptions.SingleThreadedUnaryStream:
TypeError: 'RetryOnRpcErrorClientInterceptor' object is not subscriptable

Version Number
e743be1 from 9/12/21 Kazuki Sakamoto

Additional context
I make the following change in rqnetwork.py ~line 240 and it runs fine? Haven't tested for the changes intended purpose:

self.channel = grpc.insecure_channel('%s:%s' % (cuebots[0], rqd.rqconstants.CUEBOT_GRPC_PORT)) self.channel = grpc.intercept_channel(self.channel, *interceptors)

@jasonmads jasonmads added the bug Something isn't working label Oct 1, 2021
splhack added a commit to splhack/OpenCue that referenced this issue Oct 14, 2021
Co-authored-by: jasonmads
splhack added a commit to splhack/OpenCue that referenced this issue Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant