Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 2to3 from requirements.txt #1555

Closed
lithorus opened this issue Oct 23, 2024 · 1 comment · Fixed by #1557
Closed

Remove 2to3 from requirements.txt #1555

lithorus opened this issue Oct 23, 2024 · 1 comment · Fixed by #1557
Labels
enhancement Improvement to an existing feature

Comments

@lithorus
Copy link
Contributor

lithorus commented Oct 23, 2024 •
edited
Loading

** Problem **
2to3 has been deprecated for a while now and has not been compltely removed in 3.13.

Describe the enhancement
2to3 needs to be removed to be able to support python 3.13+. It seems to only be used to fix the import in the generated proto files.

I see 3 options :

  1. Add compiled_proto to PYTHONPATH
  2. Use sed to make the import relative
  3. Create python script that converts the files (perhaps also create the files)

Edit:
Added 3rd option
@lithorus lithorus added the enhancement Improvement to an existing feature label Oct 23, 2024
@lithorus lithorus changed the title Remove 2to3 Remove 2to3 from requirements.txt Oct 23, 2024
@DiegoTavares
Copy link
Collaborator

Option 3 has my vote

@lithorus lithorus mentioned this issue Oct 24, 2024
Merged
DiegoTavares pushed a commit to DiegoTavares/OpenCue that referenced this issue Oct 28, 2024
@lithorus @DiegoTavares
Add script for converting imports in grpc python modules and remove 2…
c8a9c2b 
…to3 (AcademySoftwareFoundation#1557)

**Link the Issue(s) this Pull Request is related to.**
This is to fix AcademySoftwareFoundation#1555

**Summarize your change.**
Replaces 2to3 with a simple script that adds "from ." in front of pb2
imports.

This is done to support newer versions of python where 2to3 has been
removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add script for converting imports in grpc python modules and remove 2to3 lithorus/OpenCue
2 participants
@DiegoTavares @lithorus