Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CUEBOT_GRPC_PORT to constraints overrides in settings #909

Closed
larsbijl opened this issue Feb 7, 2021 · 0 comments · Fixed by #911
Closed

Add CUEBOT_GRPC_PORT to constraints overrides in settings #909

larsbijl opened this issue Feb 7, 2021 · 0 comments · Fixed by #911
Labels
enhancement Improvement to an existing feature

Comments

@larsbijl
Copy link
Contributor

larsbijl commented Feb 7, 2021

Describe the enhancement
Allow CUEBOT_GRPC_RQD_PORT to be overridden from the CONFIG_FILE. this will allow user to modify the GPRC client and server port without having to modify code.

should we away from using CONFIG_FILE and standardized on using environment variables to override settings? with systemd is easy enough to pass variables to services.
@larsbijl larsbijl added the enhancement Improvement to an existing feature label Feb 7, 2021
@larsbijl larsbijl linked a pull request Feb 7, 2021 that will close this issue
Make GRPC ports avaiable in settings file as override #911
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make GRPC ports avaiable in settings file as override larsbijl/OpenCue
1 participant
@larsbijl