Make GRPC ports avaiable in settings file as override #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
larsbijl
commented
Feb 7, 2021
larsbijl
commented
- Make GRPC ports available in the settings file as an override
- Remove SPI specific facility checks/overrides hardcoded in RQD
- DEFAULT_FACILITY can now be overridden to set the default facility for a RQD client.
Remove SPI specific facility checks/overrides hardcoded in RQD DEFAULT_FACILITY can now be overriden to set the default facility for a RQD client.
larsbijl
requested review from
bcipriano,
DiegoTavares,
gregdenton,
IdrisMiles,
jrray and
smith1511
as code owners
This was
linked to
issues
Feb 7, 2021
bcipriano
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
LGTM, heads up to @DiegoTavares in case they need to make some change on their side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.