Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number of GPU units in RunningFrameInfo #1017

Merged
merged 1 commit into from
Sep 12, 2021

Conversation

splhack
Copy link
Contributor

@splhack splhack commented Aug 23, 2021

Fix a bug introduced in #924

  • rqnetwork.py numGpus is always 0 😞
  • It can just use runFrame.num_gpus.
    • Because this code block is working correctly

      OpenCue/rqd/rqd/rqcore.py

      Lines 865 to 868 in c22fe12

      if runFrame.num_gpus:
      reserveGpus = self.machine.reserveGpus(runFrame.num_gpus)
      if reserveGpus:
      runFrame.attributes['GPU_LIST'] = reserveGpus

Copy link
Collaborator

@bcipriano bcipriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also makes it consistent with num_cores which is nice 👍

@bcipriano bcipriano merged commit 42ffe1f into AcademySoftwareFoundation:master Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants