Add Job.shutdownIfCompleted API #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splhack
requested review from
bcipriano,
DiegoTavares,
gregdenton,
IdrisMiles,
jrray,
larsbijl and
smith1511
as code owners
bcipriano
requested changes
Dec 4, 2021
splhack
force-pushed
the
shutdown-job-if-completed
branch
from
6bdad7a to
99599c4
Compare
|
@bcipriano sure, rebased onto master. |
bcipriano
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding
Job.shutdownIfCompletedAPI as a workaround for #1014.We observed several times FrameCompleteHandler doesn't set Job finished, most likely due to some bad state of database. We should fix the database issue, however, there is no ways to mark Job succeeded from outside of OpenCue even though all frames are marked succeeded.
Job.shutdownIfCompletedis a safe API to have Cuebot reevaluate whether the Job is completed or not, and shutdown it if it is completed.