Fix HostSearch substring for loose search #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug with cueadmin arg handler -lh, it should allow a substring match for the hosts being searched, but user was trying `-lh PARTIAL_HOST_NAME -alloc location.general`, api.getHosts uses search.HostSearch.byOptions but Criteria.java sql search was not returning any results, substring was calling addPhrase which does NOT do a SQL loose match, changed HostSearch.java to use `addLikePhrase`, this will search substrings in sql (just like JobSearch.java which uses addLikePhrase for SQL substring searches.
roulaoregan-spi
requested review from
bcipriano,
DiegoTavares,
gregdenton,
IdrisMiles,
jrray,
larsbijl and
smith1511
as code owners
DiegoTavares
approved these changes
Dec 8, 2021
bcipriano
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
Bug with cueadmin arg handler -lh, it should allow a substring match for the hosts being searched, but user
was trying
-lh PARTIAL_HOST_NAME -alloc location.general, api.getHosts uses search.HostSearch.byOptions but Criteria.java sql search was not returning any results, substring in HostSearch.java was calling addPhrase which does NOT do a SQL loose match, changed HostSearch.java to useaddLikePhrase, this will search substrings in sql (just like JobSearch.java which uses addLikePhrase for SQL substring searches.