Create feature flag to allow deeding #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
roulaoregan-spi
force-pushed
the
allow-deeding
branch
from
94cffc0 to
3f6cd42
Compare
- Set AllowDeeding=1 in general config to be able to use local cores - Use Local Cores option disabled by default
roulaoregan-spi
force-pushed
the
allow-deeding
branch
from
3f6cd42 to
44e8130
Compare
roulaoregan-spi
requested review from
bcipriano,
gregdenton,
jrray,
smith1511,
larsbijl,
DiegoTavares,
IdrisMiles and
splhack
as code owners
DiegoTavares
reviewed
Apr 8, 2022
There was a problem hiding this comment.
LGTM. I would like to have @bcipriano 's opinion as this changes a default behaviour
bcipriano
requested changes
May 10, 2022
Fix merging conflict
|
Minor comment fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
Motivation for disabling using local cores in cuetopia by default (i.e. artist desktops) from rendering was due to firstly, to mitigate slowness affecting artists due to system and network configurations for other services running on the desktop, historically the congestion caused slowness to the artist experience, and decided to avoid this chance for reintroducing congestion. Secondly, due to production management of render farm allocations per shows. Leaving the option to "opt in" and allow users to set the flag:
AllowDeeding=1in the config file read by cuegui.