-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: some SQL queries were malformed #1222
fix: some SQL queries were malformed #1222
Conversation
Some SQL query strings were missing spaces and, when appending the strings together, the resulting query had syntax issue
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change LGTM! Just need to resolve the CLA check and we can get this merged :)
@bcipriano CLA approval is being treated as we speak, I don't know how long it will take though, we'll see! 😉 |
@romainf-ubi Any update on the CLA? |
@bcipriano still waiting response from our legal department... (I kinda new this was going to be long 😞 ) |
@bcipriano I haven't forgotten you 😅 I'm hoping to have an answer during the first half of January (apparently that our legal department is a bit busy with the end of the year). Sorry for the delay (and I hope they'll approve the CLA too). |
CLA is signed! Can you re-run the CI please @bcipriano ? |
/easycla |
Awesome! I'm trying to get that CLA check to re-run, no luck so far. Hang tight, I've filed a ticket with the LF to see what's going on. |
Response from LF support:
Let me know if that works for you. |
I was added as a contributor by my CLA manager, didn't know I had to click the link again, sorry. It's done and everything's green! (I'll check my other PRs) |
Great! No worries, I didn't know you had to click the link again either :) Big thanks for navigating that process and sticking with it. |
Link the Issue(s) this Pull Request is related to.
Fixes #1221
Summarize your change.
Some SQL query strings were missing spaces and, when appending the strings together, the resulting query had syntax issue.
The main issue was in
cuebot\src\main\java\com\imageworks\spcue\dao\postgres\JobDaoJdbc.java:948
where we had this code:Which would result with that faulty string:
job_stat.int_waiting_count != 0AND
.Then I searched in the code if there were other issues like this one and found a few.
See also this message in the mailing-list: https://lists.aswf.io/g/opencue-user/topic/95205474#494