Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some SQL queries were malformed #1222

Merged

Conversation

romainf-ubi
Copy link
Contributor

Link the Issue(s) this Pull Request is related to.
Fixes #1221

Summarize your change.
Some SQL query strings were missing spaces and, when appending the strings together, the resulting query had syntax issue.

The main issue was in cuebot\src\main\java\com\imageworks\spcue\dao\postgres\JobDaoJdbc.java:948 where we had this code:

            "job_stat.int_waiting_count != 0" +
        "AND " +

Which would result with that faulty string: job_stat.int_waiting_count != 0AND.

Then I searched in the code if there were other issues like this one and found a few.

See also this message in the mailing-list: https://lists.aswf.io/g/opencue-user/topic/95205474#494

Some SQL query strings were missing spaces and, when appending the
strings together, the resulting query had syntax issue
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 24, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Collaborator

@bcipriano bcipriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM! Just need to resolve the CLA check and we can get this merged :)

@romainf-ubi
Copy link
Contributor Author

@bcipriano CLA approval is being treated as we speak, I don't know how long it will take though, we'll see! 😉

@bcipriano
Copy link
Collaborator

@romainf-ubi Any update on the CLA?

@romainf-ubi
Copy link
Contributor Author

@bcipriano still waiting response from our legal department... (I kinda new this was going to be long 😞 )

@romainf-ubi
Copy link
Contributor Author

romainf-ubi commented Dec 21, 2022

@bcipriano I haven't forgotten you 😅 I'm hoping to have an answer during the first half of January (apparently that our legal department is a bit busy with the end of the year). Sorry for the delay (and I hope they'll approve the CLA too).

@romainf-ubi
Copy link
Contributor Author

CLA is signed! Can you re-run the CI please @bcipriano ?

@bcipriano
Copy link
Collaborator

/easycla

@bcipriano
Copy link
Collaborator

Awesome!

I'm trying to get that CLA check to re-run, no luck so far. Hang tight, I've filed a ticket with the LF to see what's going on.

@bcipriano
Copy link
Collaborator

Response from LF support:

I can see the contributor was added under Ubisoft Corporate CLA approved criteria. What is missing is for the contributor to acknowledge the contribution, which can be done by accessing "Please click here to be authorized" link from the PR comment: #1222 (comment). For more detailed information please visit: https://docs.linuxfoundation.org/lfx/easycla/v2-current/contributors/corporate-contributor#acknowledge-company-contribution

Let me know if that works for you.

@romainf-ubi
Copy link
Contributor Author

I was added as a contributor by my CLA manager, didn't know I had to click the link again, sorry.

It's done and everything's green! (I'll check my other PRs)

@bcipriano
Copy link
Collaborator

Great! No worries, I didn't know you had to click the link again either :)

Big thanks for navigating that process and sticking with it.

@bcipriano bcipriano merged commit 58fcb4a into AcademySoftwareFoundation:master Jan 12, 2023
@romainf-ubi romainf-ubi deleted the fix-sql-queries branch January 12, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CueBot can't get the list of pending jobs
2 participants