Migrate stats columns from show to show_stats #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frequently changing columns on the SHOW table were causing the show indexes to bloat faster than desired and impacting the system performance, specially in the Whiteboard queries for jobs.
DiegoTavares
requested review from
bcipriano,
gregdenton,
jrray,
smith1511,
larsbijl,
IdrisMiles and
splhack
as code owners
|
@DiegoTavares Looks like there are some test failures here. |
Add gpu columns
DiegoTavares
commented
Jan 26, 2023
cuebot/src/main/java/com/imageworks/spcue/dao/postgres/WhiteboardDaoJdbc.java
Show resolved
Hide resolved
…ardDaoJdbc.java Signed-off-by: Diego Tavares da Silva <dtavares@imageworks.com>
A show_stats row needs to be created and deleted together with a show row. This bug was introduced on https://gitlab.spimageworks.com/spi/dev/infrastructure/api/opencue/-/merge_requests/427
DiegoTavares
force-pushed
the
show_stats_mirror
branch
from
20dae03 to
8090c49
Compare
bcipriano
reviewed
Jan 27, 2023
cuebot/src/main/resources/conf/ddl/postgres/migrations/V21__AddShowStats.sql
Outdated
Show resolved
Hide resolved
cuebot/src/main/resources/conf/ddl/postgres/migrations/V21__AddShowStats.sql
Outdated
Show resolved
Hide resolved
|
@DiegoTavares Ready to merge here, but we need to merge master again and re-bump the version number. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frequently changing columns on the SHOW table were causing the show indexes to bloat faster than desired and impacting the system performance, specially in the Whiteboard queries for jobs.