Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock evdev dependency for Python 2. #1248

Merged
merged 5 commits into from
Jan 21, 2023

Conversation

bcipriano
Copy link
Collaborator

@bcipriano bcipriano commented Jan 20, 2023

Installing dependencies is currently failing for Python 2:

Collecting evdev>=1.3; "linux" in sys_platform
  Downloading evdev-1.6.1.tar.gz (26 kB)
    ERROR: Command errored out with exit status 1:
     command: /usr/local/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-6TVjAa/evdev/setup.py'"'"'; __file__='"'"'/tmp/pip-install-6TVjAa/evdev/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-bH2XrD
         cwd: /tmp/pip-install-6TVjAa/evdev/
    Complete output (6 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-6TVjAa/evdev/setup.py", line 103
        cmd = [sys.executable, 'evdev/genecodes.py', *headers]

The evdev is used by our recently added pynput dependency, but only on Linux.

The evdev project dropped Python 2 support in v1.5.0, however it continued to work until now. The recent v1.6.1 release uses a syntax that is no longer compatible with Python 2.

On Linux, lock evdev to 1.4.0, the last version to support Python 2. This still satisfies pynput's requirement of evdev >= 1.3.

@bcipriano
Copy link
Collaborator Author

Merging to unbreak Python 2 tests in our pipelines.

@bcipriano bcipriano merged commit 0466051 into AcademySoftwareFoundation:master Jan 21, 2023
@bcipriano bcipriano deleted the lock-evdev branch January 21, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant