[rqd] Default to locked on override_nimby #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a server is marked with OVERRIDE_NIMBY but doesn't have the libraries required to monitor user activity (select or pynput), it should be marked as locked by default. It is safer to assume that a host that was set with OVERRIDE_NIMBY is meant to be locked from the start than available to launch jobs.
DiegoTavares
changed the title
DiegoTavares
requested review from
bcipriano and
ramonfigueiredo
as code owners
ramonfigueiredo
approved these changes
Aug 6, 2024
DiegoTavares
merged commit 94e7ed7
into
AcademySoftwareFoundation:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a server is marked with
OVERRIDE_NIMBYbut doesn't have the libraries required to monitor user activity (select or pynput), it should be marked as locked by default. It is safer to assume that a host that was set withOVERRIDE_NIMBYis meant to be locked from the start than available to launch jobs.