Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rest_gateway] Add authentication to gRPC REST gateway and include unit testing #1453

Conversation

Zach-Fong
Copy link
Contributor

Features and improvements

  1. JWT authentication for gRPC REST gateway
  • Integrated JWT authentication for secure communication.
  • Implemented middleware to validate JWT tokens from HTTP requests' authorization headers.
  1. Include unit testing
  • Added Go tests for the REST gateway to ensure authentication middleware functionality and error handling.

Co-authored-by: Zachary Fong zfong@imageworks.com
Co-authored-by: Ramon Figueiredo rfigueiredo@imageworks.com

DiegoTavares and others added 2 commits August 9, 2024 16:27
Merge changes from local fork into ASWF repo

---------

Signed-off-by: Diego Tavares <dtavares@imageworks.com>
…it testing

Features and improvements

1. JWT authentication for gRPC REST gateway
- Integrated JWT authentication for secure communication.
- Implemented middleware to validate JWT tokens from HTTP requests' authorization headers.
2. Include unit testing
- Added Go tests for the REST gateway to ensure authentication middleware functionality and error handling.

Co-authored-by: Zachary Fong <zfong@imageworks.com>
Co-authored-by: Ramon Figueiredo <rfigueiredo@imageworks.com>
@ramonfigueiredo ramonfigueiredo changed the base branch from master to rest_gateway August 9, 2024 23:33
@ramonfigueiredo
Copy link
Collaborator

Hi @DiegoTavares @bcipriano

FYI ...

I already reviewed these new changes in the rest_gateway. Everything is fine! For now, @Zach-Fong's PR will be merged into the rest_gateway branch, not the master.

This PR includes the code from @DiegoTavares: PR: Rest gateway #1449

Copy link
Collaborator

@ramonfigueiredo ramonfigueiredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zach-Fong @DiegoTavares

Approved! Thank you!

Signed-off-by: Ramon Figueiredo <rfigueiredo@imageworks.com>
@ramonfigueiredo ramonfigueiredo merged commit db5a805 into AcademySoftwareFoundation:rest_gateway Aug 9, 2024
1 check passed
@ramonfigueiredo ramonfigueiredo mentioned this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants