Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cuegui] Fix issue with jobs changing order (bouncing) when ordered on the JobMonitor plugin #1484

Merged

Conversation

DiegoTavares
Copy link
Collaborator

Issue being fixed.
When values on a columns being used for sorting repeat, jobs with similar values on the given column might change order (bounce) when the job data for other columns updates.

Summarize your change.
This fix proposed and implemented by @Samer-sef appends the job start_time to the columns sorting key to ensure sorting keys are different enough to prevent bouncing.

Copy link

linux-foundation-easycla bot commented Aug 19, 2024

CLA Missing ID CLA Not Signed

@DiegoTavares DiegoTavares marked this pull request as ready for review August 19, 2024 23:33
@ramonfigueiredo
Copy link
Collaborator

@Samer-sef's contribution to this PR happened while he was still at SPI. Even though he has signed the CLA, the check will fail as the email assigned to this commit is no longer associated with his GitHub account.

Copy link
Collaborator

@ramonfigueiredo ramonfigueiredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DiegoTavares

Approved!

@DiegoTavares DiegoTavares merged commit 549dc74 into AcademySoftwareFoundation:master Aug 21, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants