Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cuegui] Set a reasonable max value on the memory slider for the LocalBookings plugin #1487

Conversation

DiegoTavares
Copy link
Collaborator

The memory sliders were created without a max value and the default was not big enough to represent regular render nodes.

Copy link

linux-foundation-easycla bot commented Aug 20, 2024

CLA Not Signed

@DiegoTavares
Copy link
Collaborator Author

Roula's contribution to this PR happened while she was still at SPI. Even though she has signed the CLA, the check will fail as the email assigned to this commit is no longer associated with her GitHub account.

@DiegoTavares DiegoTavares marked this pull request as ready for review August 20, 2024 16:08
@DiegoTavares DiegoTavares changed the title Set a reasonable max value on the memory slider for the LocalBookings plugin [cuegui] Set a reasonable max value on the memory slider for the LocalBookings plugin Aug 20, 2024
Copy link
Collaborator

@ramonfigueiredo ramonfigueiredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DiegoTavares

Approved!

@DiegoTavares DiegoTavares merged commit 22dc4f2 into AcademySoftwareFoundation:master Aug 21, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants