[rqd] Remove hardcoded MAIL and HOME rqd environment variables #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithorus
requested review from
bcipriano,
DiegoTavares and
ramonfigueiredo
as code owners
lithorus
changed the title
DiegoTavares
requested changes
Sep 25, 2024
Comment on lines
-101
to
-104
| if platform.system() in ("Linux", "Darwin"): | ||
| self.frameEnv["MAIL"] = "/usr/mail/%s" % self.runFrame.user_name | ||
| self.frameEnv["HOME"] = "/net/homedirs/%s" % self.runFrame.user_name | ||
| elif platform.system() == "Windows": |
There was a problem hiding this comment.
These variables are spi specific and safe to be removed. As these env vars are required at SPI, I think this PR should provide a alternative to how to set these variables from now on. I guess the following logic can be used, and it should be documented on this PR.
for key, value in self.runFrame.environment.items():
if key == 'PATH':
self.frameEnv[key] += os.pathsep + value
else:
self.frameEnv[key] = valueThere was a problem hiding this comment.
rqd.conf already have a way of passing host enviroment variables onto the job (under [UseHostEnvVar])
There was a problem hiding this comment.
Have added how to re-enable them again in the PR description
DiegoTavares
approved these changes
Oct 1, 2024
DiegoTavares
merged commit 2809037
into
AcademySoftwareFoundation:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
Fixes #420
Summarize your change.
Removes hardcoded environment variables specific for SPI
If the variables are still needed, they can be exposed for the job again by adding them to the
[UseHostEnvVar]section ofrqd.conf