Update placeholder branch for containerized_rqd #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When RUN_ON_DOCKER is set on rqd.conf, each frame will be launched as a docker container using the base image configured as DOCKER_IMAGE.
Logging was added on the wrong scope, which led to a "Frame not found in cache" when a frame was actually found.
New spec is required to allow passing the layer's expected OS.
When rqd is running on docker mode, it can report multiple supported OSs. On rqd.conf, multiple images can be provided under [docker.images] and each image refers to a supported OS.
Signed-off-by: Diego Tavares <dtavares@imageworks.com>
DiegoTavares
requested review from
bcipriano and
ramonfigueiredo
as code owners
DiegoTavares
merged commit b117568
into
AcademySoftwareFoundation:containerized_rqd
10 of 12 checks passed
DiegoTavares
added a commit
to DiegoTavares/OpenCue
that referenced
this pull request
Nov 5, 2024
…ation#1550) Signed-off-by: Diego Tavares <dtavares@imageworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.