-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rqd] Rqd tests were not being executed #1560
[rqd] Rqd tests were not being executed #1560
Conversation
unittest was not reporting test failures and interruptions as expected, which caused us to be running with failed unit tests for a long time. This commit replaces unittest with pytest for rqd and fixes some of the relevant unit tests.
Signed-off-by: Diego Tavares <dtavares@imageworks.com>
@DiegoTavares I actually did some initial look into converting things to pytest. You can check some of the work in #1540 |
Since AcademySoftwareFoundation#1308 rqd stopped supporting stats files containing whitespaces and parenthesis.
There's a whole test suite dedicated to nimby, this unit test is unreliable and don't accomplish enough to justify its existence
@lithorus I propose we migrate all the python modules to pytest, similarly to what was done here. PyTest's output is way easier to follow and it is more reliable when it comes to having snippet that calls |
I agree. When testing with it I also found it to have better output, but it just seemed like a big task for what I was trying to do at the time. |
2cd3694
to
be6de81
Compare
This PR requires a blog post or documentation entry to be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with minor changes!
3341bcb
into
AcademySoftwareFoundation:master
The unit tests were not reporting test failures and interruptions as expected, which caused us to be running with failed unit tests for a long time.
This PR replaces
unittest
withpytest
for RQD and fixes some of the relevant unit tests.