[cuegui] Fix FrameContextMenu and test_rightClickItem to handle NoneType job attribute #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ramonfigueiredo
commented
Oct 29, 2024
ramonfigueiredo
commented
- Ensure the job attribute is set before triggering the context menu event.
- Mock the getLayers method to return an empty list to avoid NoneType errors.
- Ensure the job attribute is set before triggering the context menu event. - Mock the getLayers method to return an empty list to avoid NoneType errors.
ramonfigueiredo
requested review from
bcipriano and
DiegoTavares
as code owners
- Add a check to ensure the job attribute is not None before accessing its methods. - Prevents potential NoneType errors when job is not set.
ramonfigueiredo
changed the title
DiegoTavares
approved these changes
Oct 29, 2024
ramonfigueiredo
merged commit a92fca4
into
AcademySoftwareFoundation:master
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.