Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add priority to pyoutline cue backend. #625

Merged
merged 4 commits into from
Feb 7, 2021
Merged

Add priority to pyoutline cue backend. #625

merged 4 commits into from
Feb 7, 2021

Conversation

larsbijl
Copy link
Contributor

@larsbijl larsbijl commented Feb 8, 2020

Link the Issue(s) this Pull Request is related to.

Closes #493

Summarize your change.

Support new parameter in xml spec.
Set priority on job resource after insertion into jobs table

gregdenton
gregdenton approved these changes Apr 22, 2020
View reviewed changes
Copy link
Collaborator

@gregdenton gregdenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinging back on this.
If everyone is ok with the process of only updating the current dtd files, this LGTM.

@bcipriano
Copy link
Collaborator

Actually #618 added a 1.9 version, so this PR should probably be updated to add a 1.10 version I suppose.

My current thinking is, it's good to create a new schema version of every change to ensure compatibility. Even if it's not strictly necessary.

This would also include updating pyoutline to use the new schema version by default, and incrementing the minor version number in VERSION.in to signal the potential incompatibility. (We recently added a policy on this, which is new so I'd be happy to hear feedback on that if there is any.)

WDYT?

@larsbijl
Copy link
Contributor Author

I will re-work this once #761 has been merged.

Add priority to pyoutline cue backend.
c480404 
Support new parameter in xml spec.
Set priority on job resource after insertion into jobs table

Closes AcademySoftwareFoundation#493
@larsbijl larsbijl force-pushed the 493-priority-from-pyoutline branch from 77bfd95 to c480404 Compare January 30, 2021 21:37
@larsbijl
Copy link
Contributor Author

Done

@larsbijl larsbijl requested a review from bcipriano February 3, 2021 22:22
@larsbijl
Copy link
Contributor Author

larsbijl commented Feb 4, 2021

@IdrisMiles

IdrisMiles
IdrisMiles approved these changes Feb 7, 2021
View reviewed changes
Copy link
Contributor

@IdrisMiles IdrisMiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and working

@IdrisMiles IdrisMiles merged commit d9c7fd9 into AcademySoftwareFoundation:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IdrisMiles IdrisMiles IdrisMiles approved these changes

@gregdenton gregdenton gregdenton approved these changes

@jrray jrray Awaiting requested review from jrray

@smith1511 smith1511 Awaiting requested review from smith1511

@DiegoTavares DiegoTavares Awaiting requested review from DiegoTavares DiegoTavares is a code owner

@bcipriano bcipriano Awaiting requested review from bcipriano bcipriano is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

priority not being set correctly on job
4 participants
@larsbijl @bcipriano @gregdenton @IdrisMiles