Fix bug with host search where search text would be ignored. #695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
#694
Summarize your change.
I think the
if
in this handler is a bit off. From my reading, it's trying to accomplish two things:But there are two problems with the way it's currently written:
if/else
block, so it's always refreshed, even if the search term hasn't changed, so (2) above is not accomplished.The reason this doesn't crop up more often is because it's kind of difficult to trigger this handler without also changing the contents of the search box. (Hence the alt+tab in the reproduction steps in the issue.)