Change virt type from INT to BIGINT #902
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some frame is always killed by Cuebot due to the
Virtual proc did not exist
warning. Which doesn't make sense, the frame is actually running on the host.Root cause
The root cause was the proc wasn't updated due to
integer out of range
in ProcDao, when it was updating the memory stats of the frame. What is theINT
values in proc table? hereActually,
INT
is not enough for 64bit Linux VSIZE (virt.) It can exceed INT_MAX even it is divided by 1024. In fact, these are the real values Cuebot received when theinteger out of range
happened.Solution
Use BIGINT for
int_virt_used
andint_virt_max_used
.