-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint CueGUI code. #904
Merged
bcipriano
merged 16 commits into
AcademySoftwareFoundation:master
from
bcipriano:cuegui-lint
Feb 8, 2021
Merged
Lint CueGUI code. #904
bcipriano
merged 16 commits into
AcademySoftwareFoundation:master
from
bcipriano:cuegui-lint
Feb 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcipriano
requested review from
DiegoTavares,
gregdenton,
IdrisMiles,
jrray,
larsbijl and
smith1511
as code owners
February 3, 2021 18:45
larsbijl
approved these changes
Feb 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been testing it locally and it seems to be running well. as the diff is massive I've only skimmed it but it seems to be in order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
#78
Summarize your change.
Set up lint for CueGUI main and test code, and make many minor changes to get lint to pass.
This is a huge PR but shouldn't affect user-visible behavior in any way. I've tested things out locally but if anyone else can pull this down and test within their own setup, that would be great.