Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint CueGUI code. #904

Merged
merged 16 commits into from
Feb 8, 2021
Merged

Conversation

bcipriano
Copy link
Collaborator

Link the Issue(s) this Pull Request is related to.
#78

Summarize your change.
Set up lint for CueGUI main and test code, and make many minor changes to get lint to pass.

This is a huge PR but shouldn't affect user-visible behavior in any way. I've tested things out locally but if anyone else can pull this down and test within their own setup, that would be great.

@bcipriano bcipriano marked this pull request as ready for review February 3, 2021 18:45
@larsbijl larsbijl self-assigned this Feb 3, 2021
Copy link
Contributor

@larsbijl larsbijl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been testing it locally and it seems to be running well. as the diff is massive I've only skimmed it but it seems to be in order.

@bcipriano bcipriano merged commit 9e49bc8 into AcademySoftwareFoundation:master Feb 8, 2021
@bcipriano bcipriano deleted the cuegui-lint branch February 8, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants