Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate strings #907

Merged
merged 5 commits into from
Feb 7, 2021
Merged

Validate strings #907

merged 5 commits into from
Feb 7, 2021

Conversation

splhack
Copy link
Contributor

@splhack splhack commented Feb 5, 2021 •
edited
Loading

Fix #900

  • Add validation to show and shot since those conformances are critical because these names are used as log file path.
  • Enhance unit tests.

@larsbijl
Copy link
Contributor

larsbijl commented Feb 6, 2021

tested this locally and seems to work well.

IdrisMiles
IdrisMiles approved these changes Feb 7, 2021
View reviewed changes
Copy link
Contributor

@IdrisMiles IdrisMiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also tested successfully

@IdrisMiles IdrisMiles merged commit 67454c9 into AcademySoftwareFoundation:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IdrisMiles IdrisMiles IdrisMiles approved these changes

@larsbijl larsbijl larsbijl approved these changes

@bcipriano bcipriano Awaiting requested review from bcipriano bcipriano is a code owner

@DiegoTavares DiegoTavares Awaiting requested review from DiegoTavares DiegoTavares is a code owner

@gregdenton gregdenton Awaiting requested review from gregdenton

@jrray jrray Awaiting requested review from jrray

@smith1511 smith1511 Awaiting requested review from smith1511

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No validation on strings??
3 participants
@splhack @larsbijl @IdrisMiles