Simplify docker compose setup. #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Place docker-compose at the root of the project. Remove some of the variable user needed to setup with defaults. As we can asume a person is running this as a test and not in production with docker-compose. process to start is now. `docker-compose up` in the root of the project.
larsbijl
requested review from
bcipriano,
DiegoTavares,
gregdenton,
IdrisMiles,
jrray and
smith1511
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Place docker-compose at the root of the project.
Remove some of the variable user needed to setup with defaults.
We can assume a person is running this as a test and not in production
with docker-compose.
process to start is now.
docker-compose upin the root of the project.