Make sure nestedJobWhiteboard is processed in order #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roulaoregan-spi
requested review from
bcipriano,
DiegoTavares,
gregdenton,
IdrisMiles,
jrray,
larsbijl and
smith1511
as code owners
|
@bcipriano - just pinging this for a review |
bcipriano
approved these changes
Jul 29, 2021
cuebot/src/main/java/com/imageworks/spcue/dao/postgres/NestedWhiteboardDaoJdbc.java
Outdated
Show resolved
Hide resolved
cuebot/src/main/java/com/imageworks/spcue/dao/postgres/NestedWhiteboardDaoJdbc.java
Outdated
Show resolved
Hide resolved
There was a problem where depending on the order of the hashmap insertion, nested folders would not show up in the GUI. The issue was caused by using childrenMap.entrySet which doesn't concern about order. To solve this issue the map values were encapsulated in a object that implements the right sorting based on level, making sure children paths are processed before their parents.
roulaoregan-spi
force-pushed
the
fix_nested_folders
branch
from
5ef47b8 to
00ffecb
Compare
|
@bcipriano - I removed the wildcard from the imports and the debugging. |
bcipriano
approved these changes
Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
There was a problem where depending on the order of the hashmap
insertion, nested folders would not show up in the GUI. The issue
was caused by using childrenMap.entrySet which doesn't concern
about order.
To solve this issue the map values were encapsulated in a object
that implements the right sorting based on level, making sure
children paths are processed before their parents.