Fix scroll bar position from jumping back to the top #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roulaoregan-spi
requested review from
bcipriano,
DiegoTavares,
gregdenton,
IdrisMiles,
jrray,
larsbijl and
smith1511
as code owners
bcipriano
reviewed
May 27, 2021
cuegui/cuegui/JobMonitorTree.py
Outdated
| @@ -435,7 +435,7 @@ def _processUpdate(self, work, rpcObjects): | |||
| if proxy in self.__userColors: | |||
| self._items[proxy].setUserColor(self.__userColors[proxy]) | |||
|
|
|||
| self.verticalScrollBar().setValue(scrolled) | |||
| self.verticalScrollBar().setRange(scrolled, len(jobObjects.keys() - scrolled)) | |||
There was a problem hiding this comment.
Lint check is failing with:
cuegui/JobMonitorTree.py:438:60: E0602: Undefined variable 'jobObjects' (undefined-variable)
Should that be rpcObjects?
There was a problem hiding this comment.
You are correct, thanks for spotting that (was an older change I was porting over and missed that!) Thanks so much. Also I missed the line you highlighted in the logs (thanks again for that). I'll update the code
|
Ping here, looks like this should be ready to merge soon. |
roulaoregan-spi
force-pushed
the
fix-job-scroll-back
branch
from
b79eb20 to
d4f6644
Compare
Changed scroll position using the setVerticalBar() .setRange(...) and created a small scroll area between scroll position and the number of jobs monitored.
roulaoregan-spi
force-pushed
the
fix-job-scroll-back
branch
from
d4f6644 to
579fb2e
Compare
|
@bcipriano - committed the changes to fix the failure, looks like the pipeline now passes. |
bcipriano
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
A common minor annoyance we heard from our users is that when scrolling through many jobs (500+), as they scrolled down the list and double clicked on a job to see it's layers, the scroll bar would jump back up to the top, forcing the user to re-scroll back down the list if they needed to view the other jobs in that scope, ideally the scroll position should remain in the most recent position.
Solution: Changed scroll position using the
setVerticalBar().setRange(...)and created a small scroll area between scroll position and the number of jobs monitored.