problem with alias in powershell

[nerdvegas]

From tests:

Line |
   4 |  function alias_test() { "echo test_echo" $args }
     |                                           ~~~~~
     | Unexpected token '$args' in expression or statement.

Seems related to: https://github.com/nerdvegas/rez/blob/master/src/rez/tests/test_shells.py#L384
I'm unsure as to why quotes are included in the alias command.

[instinct-vfx]

I can hopefully look into this. There is an issue with PowerShell that we discussed earlier somewhere in that the command vs. parameter escapes are different and hence plain concatenating them causes issues. It's too late atm for me to remember the specifics will try and come up with a more helpful reply tomorrow.

[nerdvegas]

Cheers! Yeah what I'm not clear on is why that alias command explicitly includes the double quotes. Without them, the generated pwsh alias works fine. So I don't know that there's anything wrong specifically with pwsh shell impl..

…

On Tue, Feb 2, 2021 at 10:12 AM Thorsten Kaufmann ***@***.***> wrote: I can hopefully look into this. There is an issue with PowerShell that we discussed earlier somewhere in that the command vs. parameter escapes are different and hence plain concatenating them causes issues. It's too late atm for me to remember the specifics will try and come up with a more helpful reply tomorrow. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1017 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMOUSR6AI5QRJOSDYTFATDS44YMFANCNFSM4W5TY67A> .

[instinct-vfx]

I will try to take a look into it today. Seems @skral added this as part of other Windows fixes. Also keep in mind that different versions of PowerShell might have quite some difference.

[instinct-vfx]

How can i inspect or reproduce the error? I tried grabbing the lastest release and running the standard selftests. That yielded some weird results (the cmd tests being run in powershell trigger vscode to open the pyfiles mid-test run and i am also seeing some other oddities i wanna look into) but this particular one i do not see.

[nerdvegas]

It happened across all python versions in the macosx workflows, maybe mac-specific? Note that I only saw it in the output though, for some reason it didn't cause an error (which in itself may be another problem).

…

On Tue, Feb 2, 2021 at 8:08 PM Thorsten Kaufmann ***@***.***> wrote: How can i inspect or reproduce the error? I tried grabbing the lastest release and running the standard selftests. That yielded some weird results (the cmd tests being run in powershell trigger vscode to open the pyfiles mid-test run and i am also seeing some other oddities i wanna look into) but this particular one i do not see. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1017 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMOUSWSPXLBMNZA5UT43DLS466KFANCNFSM4W5TY67A> .

[instinct-vfx]

Got it now. And after cross checking it happens in all workflows on all platforms. Will try to look into this.

[instinct-vfx]

So i am pretty sure it is only a bug in the test definition itself. I tried building actual aliases locally and that seems to work just fine. Also removing the double quotes prevents the error locally for me.