-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rez-Bind: Override Built-in Bind Modules #1557
Comments
Hi @Pantsworth! Indeed that seems weird and is not what I would expect. Feel free to open a PR for this. It would be very appreciated! |
Pantsworth
added a commit
to Pantsworth/rez
that referenced
this issue
Jan 17, 2024
…lt-in bind modules.
Pantsworth
added a commit
to Pantsworth/rez
that referenced
this issue
Jan 17, 2024
…lt-in bind modules. Signed-off-by: Michael Nowakowski <m_nowakowski@apple.com>
JeanChristopheMorinPerso
added a commit
that referenced
this issue
Jan 27, 2024
* Issue #1557 - Add support for overriding built-in bind modules. Signed-off-by: Michael Nowakowski <m_nowakowski@apple.com> * Add copyrights Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> * Add test for get_bind_modules Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> --------- Signed-off-by: Michael Nowakowski <m_nowakowski@apple.com> Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> Co-authored-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Pixel-Minions
pushed a commit
to Pixel-Minions/rez
that referenced
this issue
Feb 14, 2024
…dation#1619) * Issue AcademySoftwareFoundation#1557 - Add support for overriding built-in bind modules. Signed-off-by: Michael Nowakowski <m_nowakowski@apple.com> * Add copyrights Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> * Add test for get_bind_modules Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> --------- Signed-off-by: Michael Nowakowski <m_nowakowski@apple.com> Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> Co-authored-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> Signed-off-by: Jose Enriquez <jose.enriquez@barnstormvfx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Rez folks!
I'm interested in overriding the built-in behavior of the
os.py
andarch.py
bind modules, so I added custom versions to bind_module_path in rezconfig.Unfortunately, search path ordering in
package_bind.py
means that the builtin bind modules end up taking priority over user-defined modules.I would expect the user-defined modules to override the builtins (this is how plugin_path works, for example -- a custom env.py overrides the builtin env.py command).
rez/src/rez/package_bind.py
Line 25 in 73e7493
Environment
To Reproduce
bind_modules
directorybind_modules
directory toREZ_BIND_MODULE_PATH
rez-bind os
Expected behavior
My expectation is that my custom os.py module will be called.
Actual behavior
The builtin os.py is called.
Related Issues/PRs
Happy to file a PR for this one - I think it's a matter of changing:
to:
The text was updated successfully, but these errors were encountered: