Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install-as-rez-package script for Windows #1014

Merged

Conversation

davidlatwe
Copy link
Contributor

Problem

  1. Python executable path was assembled by os.path.join(tmpdir, "bin", "python"), which will not work on Windows. (dir name is scripts instead of bin).

  2. repo_path that has \\ in it will not be properly escaped.

Solution

  1. Replace hardcoded bin dir path with virtual env helper function.
  2. Format repo_path with repr()

@nerdvegas nerdvegas merged commit b3c8593 into AcademySoftwareFoundation:master Feb 23, 2021
@davidlatwe davidlatwe deleted the fix-install-rez-as-pkg branch March 2, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants