Avoid hidden folder/files as it introduces problems on certain fileystems #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stems Prefixing file/folders . on certain Linux file servers, that are mounted via samba to Windows makes the folders hidden. But in edgecases the rename retains the hidden attribute after the rename without the . prefix. We observed this on rez-cp. Some client applications (Autodesk Maya) refuses to work with hidden files. As such avoid using hidden files for temporary artifacts for sanity sake.
|
Using Windows + Linux file server here too, but haven't use |
|
Ok I um'd and ah'd about this for a bit because it seems potentially dangerous, but the only use case I can see currently is indeed package_copy, and I think that any temporary non-hidden files/dirs within a copied variant's payload dir shouldn't cause problems. I'll merge this but will add a comment clarifying why the tempdir isn't hidden (which will seem counter-intuitive without an explanation). |
|
@davidlatwe in our case it was scripts or plugins I believe. Totally weird, I have to check the details with the TD involved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure what the right solution is. Config variable? Windows vs. Linux case? Either way here is
a fix to a very tricky issue that might affect others considering that . prefix is not a happy story in Windows
anyway:
Prefixing file/folders . on certain Linux file servers, that are mounted
via samba to Windows makes the folders hidden. But in edgecases the rename
retains the hidden attribute after the rename without the . prefix.
We observed this on rez-cp.
Some client applications (Autodesk Maya) refuses to work with hidden files.
As such avoid using hidden files for temporary artifacts for sanity sake.