Added a configuration option for rez-pip dist-info remapping #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine with this being default behaviour rather than configurable, unless there are objections? |
|
Closing in favor of #1128 as there are no objections to hardcoding this behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this PR to get some traction on #892 .
This PR keeps the current behavior, but lets us configure the current "special-case" in rez-pip that always copies dist-info files to the rez-package root.
By setting
pip_install_override_dist_info_remap = False, dist-info files will end up alongside the python package as some tools expect.In my opinion the better solution would be to just change the default behavior and copy the files to where they are expected.