Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows CI upgrade #1185

Merged
merged 34 commits into from
Feb 8, 2022
Merged

windows CI upgrade #1185

merged 34 commits into from
Feb 8, 2022

Conversation

nerdvegas
Copy link
Contributor

Fixes #1181

This PR introduces a bunch of changes to improve the situation wrt windows CI tests. Specifically:

  • Previously, windows.yaml would use the tagged image generated by windows-docker-image.yaml (where tag is the latest commit hash of relevant workflow/docker files). This breaks when a change is made that triggers both an image rebuild, and the windows workflow, since the new image isn't built yet. Now, windows.yaml just uses latest image instead.
  • Updated windows-docker-image.yaml to generate artifacts that contain docker inspect info, for the images generated. This is for debugging purposes
  • Updated windows.yaml to print the specific tag of the image it's using, to be able to verify that it is actually using the latest image as expected
  • reworked path/path-ignore filters across all workflows - now uses combined include/exclude form to better target files to trigger workflow runs from
  • fixed bug causing choco-cleanup to fail. It's reporting deletion of ~300Mb of files now, so images should be considerably smaller
  • general cleanup of workflow run code to be cleaner and easier to follow
  • avoid using env-vars when standard pwsh var will do
  • run pytest-based selftest on windows to match other os workflows
  • drop use of DOCKER_CLI_EXPERIMENTAL feature, not supposed to be used in production
  • moved py version into the image name, required in order for windows.yaml to be able to pull latest image

-generate json artifact on docker img build
-added artifacts on build of py imgs
-ignore docker files in 'installation' workflow
-not so useful as very often the workflows you don't want to trigger get triggered anyway
-fix chocolatey in py Dockerfile
-tag and push latest for windows.yaml to pull
-print non-latest image tag for debugging
-some formatting improvements
-added some more verbosity
Copy link
Contributor

@davidlatwe davidlatwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🍻
I also notice that windows.yaml workflow isn't testing with Python 3 for a long while, maybe we could re-enable it now ?

.github/workflows/flake8.yaml Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nerdvegas nerdvegas merged commit 886acd7 into master Feb 8, 2022
@bpabel bpabel deleted the issue_1181-win-docker branch January 19, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windows gh actions issue
2 participants