-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows CI upgrade #1185
Merged
Merged
windows CI upgrade #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-generate json artifact on docker img build
-added artifacts on build of py imgs
-ignore docker files in 'installation' workflow
-long live echo
-not so useful as very often the workflows you don't want to trigger get triggered anyway
-fix chocolatey in py Dockerfile -tag and push latest for windows.yaml to pull
-print non-latest image tag for debugging
…on-no-build-stage-in-current-context
-some formatting improvements -added some more verbosity
davidlatwe
reviewed
Dec 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🍻
I also notice that windows.yaml
workflow isn't testing with Python 3 for a long while, maybe we could re-enable it now ?
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1181
This PR introduces a bunch of changes to improve the situation wrt windows CI tests. Specifically: