Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aliases in windows powershell/pwsh #1192

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Fix aliases in windows powershell/pwsh #1192

merged 1 commit into from
Feb 8, 2022

Conversation

alx00x
Copy link
Contributor

@alx00x alx00x commented Jan 27, 2022

fixes #1191

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alx00x alx00x marked this pull request as draft January 27, 2022 10:14
@alx00x alx00x marked this pull request as ready for review January 27, 2022 17:50
@nerdvegas
Copy link
Contributor

Good find. I tracked this down, it was introduced in v2.98.1. It was an unintended side-effect of removing a small amount of code (2 lines) for licensing reasons, and neglecting to realise that the .format(...) (which was replaced by old-school %s replacement) was collapsing those double curly braces.

@nerdvegas nerdvegas merged commit f1ce232 into AcademySoftwareFoundation:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aliases broken on windows when using powershell
2 participants
@alx00x @nerdvegas