Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use forward slashes in PowerShell #1351

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

anderslanglands
Copy link

PowerShell consumes forward slashes in path names just fine. CMake occasionally barfs on backslashes. Therefore this PR just uses forward slashes for pwsh and everything is happy.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 24, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: anderslanglands / name: Anders Langlands (0a9f169, 03257cb)

Signed-off-by: Anders Langlands <anderslanglands@gmail.com>
Signed-off-by: Anders Langlands <anderslanglands@gmail.com>
@ColinKennedy
Copy link

Previous PR, for context: #1273

Considering that CMake apparently misbehaves even in Windows with proper, normalized paths, I'd rather normalization be an explicit, opt-in feature so that projects that require this custom behavior can still have it and the default, expected behavior still functions as expected. This PR doesn't give the user any option to opt-in / opt-out of the change. What if something else other than CMake needs backslashes? etc.

@nerdvegas
Copy link
Contributor

Hey Anders,

Please see the discussion in #1302 as I think this really is the root of the issue. Feel free to add to that thread, it needs to be picked up again. But yes this stuff does need to be fixed, I just think we need to do so in a more general way (as this is not a powershell specific thing).

@maxnbk maxnbk requested a review from a team as a code owner November 15, 2022 23:58
@JeanChristopheMorinPerso JeanChristopheMorinPerso requested a review from a team as a code owner April 4, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants