Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to pass extra arguments to underlying rez test command (REP-001 part 3). #1523

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Allow user to pass extra arguments to underlying rez test command (REP-001 part 3). #1523

merged 1 commit into from
Sep 11, 2023

Conversation

bhawkyard1
Copy link
Contributor

This addresses point 3 of #665, as discussed on the aswf rez slack channel recently, allowing users to pass arguments from invocation of rez test down to the underlying test command that gets run.

@bhawkyard1 bhawkyard1 requested a review from a team as a code owner August 27, 2023 11:01
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 27, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bhawkyard1 / name: Ben Hawkyard (dc3ec96)

@bhawkyard1 bhawkyard1 force-pushed the feature/issue_665-rez-test-extra-args branch from 341dbb2 to be318a2 Compare August 27, 2023 11:07
JeanChristopheMorinPerso
JeanChristopheMorinPerso requested changes Aug 27, 2023
View reviewed changes
Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bhawkyard1 for creating this PR! It'll be really useful to a lot of our users.

I left a comment that will need to be addressed before we can approve this PR.

src/rez/package_test.py Outdated Show resolved Hide resolved
@JeanChristopheMorinPerso JeanChristopheMorinPerso force-pushed the feature/issue_665-rez-test-extra-args branch from be318a2 to ed0433b Compare August 28, 2023 01:16
@JeanChristopheMorinPerso
Copy link
Member

I rebased your branch to fix the CI.

@bhawkyard1
Copy link
Contributor Author

I rebased your branch to fix the CI.

Awesome, thank you!

@bhawkyard1 bhawkyard1 force-pushed the feature/issue_665-rez-test-extra-args branch from ed0433b to dc3ec96 Compare August 28, 2023 17:07
@bhawkyard1
Copy link
Contributor Author

Hey there, I can see the readthedocs ci step failed, I am not sure I understand how to fix this though?

@JeanChristopheMorinPerso
Copy link
Member

Hi @bhawkyard1 , it's fine. We'll handle that failure for you. You don't need to do anything.

I kicked the actions and everything seems to be passing.

@maxnbk maxnbk added this to the Next milestone Sep 6, 2023
JeanChristopheMorinPerso
JeanChristopheMorinPerso approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bhawkyard1! I'm sure this will be a very welcome change to all our users!

@bhawkyard1
Copy link
Contributor Author

Thanks @bhawkyard1! I'm sure this will be a very welcome change to all our users!

Awesome, thanks for the feedback and help!

@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit c49611c into AcademySoftwareFoundation:master Sep 11, 2023
29 checks passed
@JeanChristopheMorinPerso JeanChristopheMorinPerso mentioned this pull request Sep 11, 2023
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanChristopheMorinPerso JeanChristopheMorinPerso JeanChristopheMorinPerso approved these changes

Assignees
No one assigned
Labels
rez-test
Projects
None yet
Milestone
2.113.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bhawkyard1 @JeanChristopheMorinPerso @maxnbk