Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake build in Windows for CMAKE_MODULE_PATH force to use "/" #1548

Conversation

loonghao
Copy link
Contributor

@loonghao loonghao commented Oct 18, 2023

We get same issues with #1321, this PR should be fix this issue.

CMake Error at Z:/PycharmProjects/maya_cvwrap/.rez_build/platform-windows/maya-2023/CMakeFiles/CMakeTmp/CMakeLists.txt:2 (set):
  Syntax error in cmake code at

    Z:/PycharmProjects/maya_cvwrap/.rez_build/platform-windows/maya-2023/CMakeFiles/CMakeTmp/CMakeLists.txt:2

  when parsing string

    G:\pkg\rez\2.113.0\platform-windows\rezplugins\build_system\cmake_files

  Invalid character escape '\r'.

@loonghao loonghao requested a review from a team as a code owner October 18, 2023 07:43
@loonghao loonghao force-pushed the fix_cmake_build_in_windows branch from ea5913a to 942a83c Compare October 19, 2023 05:57
Signed-off-by: loonghao <hal.long@outlook.com>
@loonghao loonghao force-pushed the fix_cmake_build_in_windows branch from 942a83c to 22aad9b Compare October 19, 2023 06:02
@JeanChristopheMorinPerso
Copy link
Member

Hi @loonghao , thanks for taking the time to open a PR. have you looked at #1475? I think it would solve your issue. Basically, doing what you suggest is only fixing part of the problem. See my comment at #1321 (comment).

#1475 fixes the real problem. The title says that it's GitBash related, but it's not just related to that. Do you want to give it a go and see if it fixes the issue?

@loonghao
Copy link
Contributor Author

@JeanChristopheMorinPerso I have tested #1475 this can fixes the real problem, closing the PR.

@loonghao loonghao closed this Oct 23, 2023
@JeanChristopheMorinPerso
Copy link
Member

Great to hear that it fixes the issue! Did you try with enable_path_normalization set ot True or False?

@loonghao
Copy link
Contributor Author

Great to hear that it fixes the issue! Did you try with enable_path_normalization set ot True or False?

I just build from the branch to local, and then the config was not modified. enable_path_normalization=False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants