Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default shell on Windows to "powershell" #1578

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Set default shell on Windows to "powershell" #1578

merged 2 commits into from
Feb 8, 2024

Conversation

JeanChristopheMorinPerso
Copy link
Member

Fixes #1559.

Set default shell on Windows to "powershell".

Note that I'm not 100% sure if this is really how it should be done. I couldn't find a better way.

@JeanChristopheMorinPerso JeanChristopheMorinPerso added this to the 3.0.0 milestone Nov 11, 2023
@JeanChristopheMorinPerso JeanChristopheMorinPerso requested a review from a team as a code owner November 11, 2023 19:20
@brycegbrazen
Copy link
Contributor

LGTM. Thanks for the doc updates as well!

@herronelou
Copy link
Contributor

Would probably need #1505 to prevent too many issues.

@JeanChristopheMorinPerso
Set default shell on Windows to "powershell"
13dc3c9 
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
@JeanChristopheMorinPerso
Adapt docstring
03e2ecf 
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
@JeanChristopheMorinPerso
Copy link
Member Author

I tested on Windows from a cmd shell:

C:\Users\jeanchristophemorin1>.\rezinstall\Scripts\rez\rez-env.exe

You are now in a rez-configured environment.

resolved by jeanchristophemorin1@windows-2, on Thu Feb 08 00:14:31 2024, using Rez v2.114.1

requested packages:
~platform==windows           (implicit)
~arch==AMD64                 (implicit)
~os==windows-10.0.20348.SP0  (implicit)

resolved packages:
> $ echo $PSVersionTable.PSEdition
Desktop

So it seems to be working as expected. It created a powershell (not pwsh) shell.

@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit c700e99 into AcademySoftwareFoundation:main Feb 8, 2024
55 checks passed
@JeanChristopheMorinPerso JeanChristopheMorinPerso deleted the change_default_shell_on_win branch February 8, 2024 00:16
Pixel-Minions pushed a commit to Pixel-Minions/rez that referenced this pull request Feb 14, 2024
@JeanChristopheMorinPerso
Set default shell on Windows to "powershell" (AcademySoftwareFoundati…
a0ec28d 
…on#1578)

Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Jose Enriquez <jose.enriquez@barnstormvfx.com>
PiloeGAO added a commit to PiloeGAO/rez that referenced this pull request Sep 4, 2024
@PiloeGAO
Revert "Set default shell on Windows to "powershell" (AcademySoftware…
fa8acee 
…Foundation#1578)"

This reverts commit c700e99.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brycegbrazen brycegbrazen brycegbrazen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Change default shell on Windows to PowerShell
3 participants
@JeanChristopheMorinPerso @brycegbrazen @herronelou