-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert all plugin rezconfig to rezconfig.py #1692
Convert all plugin rezconfig to rezconfig.py #1692
Conversation
Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com>
Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1692 +/- ##
==========================================
+ Coverage 58.25% 58.27% +0.01%
==========================================
Files 126 126
Lines 17157 17157
Branches 3504 3504
==========================================
+ Hits 9995 9998 +3
+ Misses 6496 6494 -2
+ Partials 666 665 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com>
Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com>
Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com>
Thanks @brycegbrazen. Did you notice a performance different between loading configs from python files instead of YAML? I feel like it'll be slightly faster with python files than with YAML since YAML is hard to parse and hence slow. But we should check to make sure there is no unexpected regression. We could use https://github.com/sharkdp/hyperfine to test |
@JeanChristopheMorinPerso I didn't benchmark anything at this point, but that does sound like a great idea. Should |
I ran hyperfine before my update (on main):
And then after the update:
|
Thanks. I also tested on my machine and I see approximately the same stats for both:
|
(correction, I wrongly installed rez in the previous run, my bad)
|
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
1b9c72a
into
AcademySoftwareFoundation:main
…on#1692) Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com> Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> Co-authored-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Effectively copied over work that @nerdvegas did back on this commit.
Closes #525.