Fix key error on getting the "testing" key on older contexts #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing" key on older contexts Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1863 +/- ##
=======================================
Coverage 59.28% 59.28%
=======================================
Files 126 126
Lines 17217 17217
Branches 3017 3017
=======================================
Hits 10207 10207
Misses 6325 6325
Partials 685 685 ☔ View full report in Codecov by Sentry. |
JeanChristopheMorinPerso
force-pushed
the
fix_key_error_testing
branch
from
517230a to
75c3177
Compare
JeanChristopheMorinPerso
merged commit 9c0fe83
into
AcademySoftwareFoundation:main
47 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1862.
Now with a test to make sure we never regress.