rex: don't let packages pollute namespace of future packages #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerdvegas
reviewed
Mar 11, 2017
| exec_namespace=self.globals) | ||
| finally: | ||
| self.globals.clear() | ||
| self.globals.update(saved_globals) |
There was a problem hiding this comment.
I'm gonna do this as a separate release anyway, since there's the outside chance that a studio is accidentally relying on this buggy behavior (and it'll be clearer to point that out in a separate release).
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package executor currently has a bug where the global namespace is shared when multiple packages are executed when setting up a context. This can create differing behavior depending on the order of execution of packages, which is clearly undesired.
This fix patches the behavior, so that the global namespace in which each package executes is "reset" after each package runs.