Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/add support for reversed version range #618

Merged
merged 2 commits into from
Jun 4, 2019
Merged

Fix/add support for reversed version range #618

merged 2 commits into from
Jun 4, 2019

Conversation

instinct-vfx
Copy link
Contributor

This is a new pull request replacing #470 because i managed to completely fubar the original one. This is based off current master (which is 2.29.1)

Thanks a lot to @skral for fixing some issues in my original PR and for adding tests!

Sorry for the hassle, i shall take more care in the future.

@nerdvegas
Copy link
Contributor

Merging this now. Please note that the docstring here should have been updated (but no worries I am doing that!): https://github.com/nerdvegas/rez/blob/master/src/rez/vendor/version/version.py#L723

I also noticed that while there are docs on version format in the wiki, there isn't for version range syntaxes. I will add that also, in a separate PR.

Cheers
A

@nerdvegas nerdvegas merged commit d35da2c into AcademySoftwareFoundation:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants